Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks API: Improve validation after block gets filters applied #14529

Merged
merged 5 commits into from Mar 28, 2019

Conversation

Projects
None yet
3 participants
@gziolo
Copy link
Member

commented Mar 20, 2019

Description

Follow-up for #14510.

It does three things:

  • addressed @aduth's suggestion to bring back removed unit test (#14510 (comment)).
  • adds a new error validation message which makes it clear that settings object got corrupted.
  • adds CHANGELOG entry which I missed...

How has this been tested?

npm run test-unit

Types of changes

Refactoring.

@gziolo gziolo force-pushed the update/block-registration-validation branch from e7634c9 to a604566 Mar 20, 2019

@aduth

aduth approved these changes Mar 27, 2019

Show resolved Hide resolved packages/blocks/src/api/registration.js Outdated
Show resolved Hide resolved packages/blocks/CHANGELOG.md Outdated

gziolo added some commits Mar 28, 2019

Apply suggestions from code review
Co-Authored-By: gziolo <grzegorz@gziolo.pl>

@gziolo gziolo merged commit 406baf1 into master Mar 28, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@gziolo gziolo deleted the update/block-registration-validation branch Mar 28, 2019

@gziolo gziolo added this to the 5.4 (Gutenberg) milestone Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.