Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Blocks Tutorial to match Gutenberg Examples #14584

Merged
merged 17 commits into from Mar 28, 2019
Merged

Conversation

@mkaz
Copy link
Member

mkaz commented Mar 22, 2019

Description

Updates the block tutorial in Gutenberg Handbook to match the Gutenberg Examples repo.
I cleaned up a few other minor changes, and small fixes.

Fixes #14005

Fixes WordPress/gutenberg-examples#20

Types of changes

Documentation.

mkaz added 5 commits Mar 22, 2019
Copy link
Member

chrisvanpatten left a comment

Small tweak but otherwise great. I didn't vet the code too closely, FYI :)

Co-Authored-By: mkaz <marcus@mkaz.com>
@mkaz mkaz mentioned this pull request Mar 23, 2019
2 of 5 tasks complete
nosolosw and others added 4 commits Mar 25, 2019
…writing-your-first-block-type.md

Co-Authored-By: mkaz <marcus@mkaz.com>
@mkaz

This comment has been minimized.

Copy link
Member Author

mkaz commented Mar 25, 2019

@nosolosw all the suggestions were implemented, thanks!

@mkaz mkaz requested a review from chrisvanpatten Mar 25, 2019
@nosolosw nosolosw self-requested a review Mar 26, 2019
Copy link
Member

nosolosw left a comment

I've pushed some fixes and all examples are now fully functioning. Let's have this 🚢

@gziolo

This comment has been minimized.

Copy link
Member

gziolo commented Mar 27, 2019

Great work, for better or worse we have both gutenberg-examples and this tutorial aligned. However, I noticed that in some places we could further improve gutenberg-examples. I think that would be great to focus on it on one of the Contributor Days at WordCamps :)

@nosolosw

This comment has been minimized.

Copy link
Member

nosolosw commented Mar 27, 2019

@chrisvanpatten have been your changes addressed? I think we can't merge until you either clear the "requested changes" status or give a 👍 (at least I don't see the option).

@nosolosw nosolosw mentioned this pull request Mar 27, 2019
0 of 4 tasks complete
@chrisvanpatten chrisvanpatten dismissed their stale review Mar 28, 2019

Changes addressed

@mkaz mkaz merged commit cd2da7d into master Mar 28, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@nosolosw nosolosw deleted the docs/14005/blocks-tutorial branch Mar 28, 2019
@youknowriad youknowriad added this to the 5.4 (Gutenberg) milestone Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.