Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data: Avoid assuming persisted preferences shape #14692

Merged
merged 1 commit into from Mar 29, 2019

Conversation

@aduth
Copy link
Member

aduth commented Mar 28, 2019

Related: #14580, #14691

This pull request seeks to update references to persisted preferences objects to avoid assumed shape of individual property values within preferences. See #14580 for additional context.

Testing instructions:

Verify unit tests pass:

npm run test-unit

Extra credit: Verify no regressions in affected behavior (insert usage, feature activation, active sidebar, NUX dismissed tips).

@gziolo
gziolo approved these changes Mar 29, 2019
Copy link
Member

gziolo left a comment

This looks great. Thanks for doing an extensive audit of existing selectors 💯

@gziolo gziolo merged commit ae3a09e into master Mar 29, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@gziolo gziolo deleted the update/avoid-assumed-preferences-shape branch Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.