Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Accessibility Mark I - Button #14697

Merged
merged 2 commits into from Apr 3, 2019

Conversation

Projects
None yet
4 participants
@etoledom
Copy link
Contributor

commented Mar 29, 2019

This PR improves the Accessibility features of the Button component.

To test:

@etoledom etoledom requested a review from pinarol Mar 29, 2019

@etoledom etoledom self-assigned this Mar 29, 2019

@etoledom etoledom marked this pull request as ready for review Mar 29, 2019

@pinarol

pinarol approved these changes Apr 1, 2019

Copy link
Contributor

left a comment

Tested with steps on parent PR

@Tug

Tug approved these changes Apr 2, 2019

Copy link
Contributor

left a comment

LGTM 👍

@etoledom etoledom merged commit 342961e into master Apr 3, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
@etoledom

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

Thank you both!

@etoledom etoledom deleted the rnmobile/accessibility-mark-i branch Apr 3, 2019

@youknowriad youknowriad added this to the 5.5 (Gutenberg) milestone Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.