Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Ensure correct attributes are always used for embed preview #14748
When pasting a YouTube URL multiple times, the responsive styles are not applied on the first render, and so the second render is incorrect and either has scrollbars or whitespace.
This change make sure we are always rendering using the correct attributes, generated from the preview.
How has this been tested?
Paste a YouTube URL, e.g. https://www.youtube.com/watch?v=wSaoXwQzHnY multiple times into a new post. Each video should be responsive with no large amounts of whitespace or scrollbars.
Types of changes
requested review from
Apr 1, 2019
Howdy @notnownikki is there a particular browser this happens on, because I tested the way you described and there appears to be no bug on master.
On master, after pasting the YouTube PR multiple times I get this:
On this PR, after pasting the YouTube PR multiple times I get this:
What am I missing and how to test :)?