Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
RichText/Input Interaction: use ZWNBSP as padding #14846
If we use zero width spaces as padding, the calculation is more reliable, and Firefox doesn't have any issues.
It also fixes an issue in the list block, where to browser moves the selection from an empty text element between a br and nested list to the start of the nested list.
How has this been tested?
Types of changes
requested review from
Apr 5, 2019
2 times, most recently
Apr 19, 2019
aduth left a comment
The build failure appears to be legitimate. I can also reproduce locally that when pressing ArrowDown from a bottom-padded paragraph, the caret is not placed in the text field (though the
Testing again, I still observe issues, though in my case it works for the ArrowDown from the padded field, but the caret becomes lost when pressing ArrowUp to try to get back to the first field.
I created a screen recording in case it helps provide any useful context: https://cloudup.com/crRofrsTvMJ
In debugging, I notice that in
Unclear if this might explain the issue (it's trying to move the selection into the hidden toolbar button?). I'm assuming the
If you're having trouble reproducing, it may be that you're configured to use the Fixed toolbar?