Reduce memory footprint of rich text values #14897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
aduth,
jorgefilipecosta and
youknowriad
as code owners
ellatrix
added
[Type] Performance
|
Has failing e2e tests. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Still needs unit tests.]
This change ensures that format arrays are reused for multiple characters in a row. We already reuse the format objects themselves, but not the array containing them, if the contents are the same.
Before:
It also makes
normaliseFormatsfaster for already normalised values, because it can now use the array reference to check equality.How has this been tested?
Screenshots
Types of changes
Checklist: