Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with color swatch focus style #14944

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@jasmussen
Copy link
Contributor

commented Apr 12, 2019

When you focus a color swatch, the circle around the check is offset.

Removing the border that this PR removes, fixes that, and appears to not have any side-effects.

I'm not sure how it regressed.

Before:

before

After:

after

Fix regression with color swatch focus style
When you focus a color swatch, the circle around the check is offset.

Removing the border that this PR removes, fixes that, and appears to not have any side-effects.

I'm not sure how it regressed.

@jasmussen jasmussen requested a review from chrisvanpatten as a code owner Apr 12, 2019

@jasmussen jasmussen self-assigned this Apr 12, 2019

@youknowriad
Copy link
Contributor

left a comment

Thanks for the quick fix @jasmussen LGTM 👍

@jasmussen

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

Thank you. Feel free to merge this one in the appropriate milestone when the checks pass. But otherwise, I'd appreciate a sanity check on why this regressed in the first place. @kjellr any idea?

@kjellr

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

I'd appreciate a sanity check on why this regressed in the first place. @kjellr any idea?

Yep, the position: relative added in this commit seems to have broken it:

666eeb9#diff-9863eacb8cd51ff65e89266486cdc139

That does appear necessary for the tooltip to show up, and your fix here doesn't seem to break anything, so I think we're ok. 👍 I'll merge in and assign to 5.5, alongside that patch.

@kjellr kjellr added this to the 5.5 (Gutenberg) milestone Apr 12, 2019

@kjellr kjellr merged commit eb23a67 into master Apr 12, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@kjellr kjellr deleted the fix/color-swatch-regression branch Apr 12, 2019

mchowning added a commit to mchowning/gutenberg that referenced this pull request Apr 15, 2019

Fix regression with color swatch focus style (WordPress#14944)
When you focus a color swatch, the circle around the check is offset.

Removing the border that this PR removes, fixes that, and appears to not have any side-effects.

I'm not sure how it regressed.

aduth added a commit that referenced this pull request Apr 15, 2019

Fix regression with color swatch focus style (#14944)
When you focus a color swatch, the circle around the check is offset.

Removing the border that this PR removes, fixes that, and appears to not have any side-effects.

I'm not sure how it regressed.

aduth added a commit that referenced this pull request Apr 16, 2019

Fix regression with color swatch focus style (#14944)
When you focus a color swatch, the circle around the check is offset.

Removing the border that this PR removes, fixes that, and appears to not have any side-effects.

I'm not sure how it regressed.

aduth added a commit that referenced this pull request Apr 16, 2019

Fix regression with color swatch focus style (#14944)
When you focus a color swatch, the circle around the check is offset.

Removing the border that this PR removes, fixes that, and appears to not have any side-effects.

I'm not sure how it regressed.

aduth added a commit that referenced this pull request Apr 16, 2019

Fix regression with color swatch focus style (#14944)
When you focus a color swatch, the circle around the check is offset.

Removing the border that this PR removes, fixes that, and appears to not have any side-effects.

I'm not sure how it regressed.

This was referenced Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.