Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: remove __unstablePositionedAtSelection #15035

Merged
merged 3 commits into from May 1, 2019

Conversation

@ellatrix
Copy link
Member

commented Apr 18, 2019

Description

#14938 follow-up.

  • Removes the use of __unstablePositionedAtSelection.
  • Fixes an issue where anchorRect is passed to a plain component.

How has this been tested?

Insert and image, ensure the toolbar is positioned correctly and repositions when you change the width or select a different image.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@aduth

aduth approved these changes Apr 29, 2019

Copy link
Member

left a comment

The review notes should be addressed, but are general clean-up tasks.

Show resolved Hide resolved packages/components/src/popover/index.js Outdated
Show resolved Hide resolved packages/dom/src/dom.js
Show resolved Hide resolved packages/block-editor/src/components/writing-flow/index.js

@ellatrix ellatrix force-pushed the try/remove-position-at-selection branch from c0e134d to 6e0cb83 May 1, 2019

@ellatrix

This comment has been minimized.

Copy link
Member Author

commented May 1, 2019

Thanks!

@ellatrix ellatrix merged commit a9a3907 into master May 1, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@ellatrix ellatrix deleted the try/remove-position-at-selection branch May 1, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.