Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Block movers don't appear on the playground and on the widgets page #15076

Conversation

Projects
None yet
4 participants
@jorgefilipecosta
Copy link
Member

commented Apr 19, 2019

The keyframe animations contained a comment saying they need to be duplicated, but they were not being duplicated in widgets and playground styles this made the block movers invisible.
This PR fixes the problem by duplicating the animation styles that needed to be duplicated.

How has this been tested?

I went to Gutenberg playground npm run playground:start. I added multiple blocks and verified the block movers appear when I hover a block.
I went to the Gutenberg widgets page /wp-admin/admin.php?page=gutenberg-widgets and repeated the test described above.

// These keyframes should not be part of the _animations.scss mixins file.
// Because keyframe animations can't be defined as mixins properly, they are duplicated.
// Since hey are intended only for the editor, we add them here instead.
@keyframes edit-post__loading-fade-animation {

This comment has been minimized.

Copy link
@youknowriad

youknowriad Apr 19, 2019

Contributor

This makes me think this animations should probably be moved to the movers stylesheet, if it's common to all usage of the editor movers?

This comment has been minimized.

Copy link
@jasmussen

jasmussen Apr 22, 2019

Contributor

It looks like this animation is reused in a few places, for example for the transient state in the file block, and the saving state for the save indicator. I imagine we'll want to use this in additional places, so it's nice with a mixin to help us create consistent animations.

but it does feel weird to keep duplicating these keyframes.

As a fix to the problem, 👍 👍 from me, but CC: @kjellr if you have any ideas as to how we can better reuse this animation and avoid the duplication.

This comment has been minimized.

Copy link
@youknowriad

youknowriad Apr 22, 2019

Contributor

Is there a way to move this animation to the Animate component?

This comment has been minimized.

Copy link
@kjellr

kjellr Apr 22, 2019

Contributor

Yeah, I was thinking it'd be great to consolidate all of the keyframe animations that we reuse into a single place — they're currently all over the place. The animate component might be a good place for that.

That definitely seems like something that could be handled in a separate PR though. This one seems 👍 to me.

@jorgefilipecosta jorgefilipecosta force-pushed the fix/block-movers-do-not-appear-on-the-playground-and-on-the-widgets-page branch from 9c33ab3 to ff6c8a1 May 6, 2019

@jorgefilipecosta jorgefilipecosta force-pushed the fix/block-movers-do-not-appear-on-the-playground-and-on-the-widgets-page branch from ff6c8a1 to 0d52ae1 May 6, 2019

@jorgefilipecosta

This comment has been minimized.

Copy link
Member Author

commented May 6, 2019

Merging this as it looks like it got @kjellr approval, and with this changes on we can continue fixing bugs on the widget screen and make them easier testable. I will try to consolidate the style in the animate component as suggested in parallel.

@jorgefilipecosta jorgefilipecosta merged commit ef95cb9 into master May 6, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/block-movers-do-not-appear-on-the-playground-and-on-the-widgets-page branch May 6, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.