Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore block movers to focus mode #15109

Merged
merged 2 commits into from Apr 26, 2019

Conversation

@kjellr
Copy link
Contributor

commented Apr 22, 2019

Closes #14670.

Currently Focus mode does not include a way to rearrange blocks. This PR corrects that by re-adding block movers to that mode. Conceptually, these seem fine to re-introduce because the movers shouldn't necessarily break your focus anyway: they only appear when you hover on a specific part of a block, and they fade away when you type.

Before:

Screen Shot 2019-04-22 at 12 26 40 PM

After:

Screen Shot 2019-04-22 at 12 26 32 PM

@draganescu

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

hi @kjellr I ran the code and the block mover is too close to the block toolbar, tried with twentynineteen and twentyfourteen

Screenshot 2019-04-22 at 20 05 11

Screenshot 2019-04-22 at 20 04 23

Screenshot 2019-04-22 at 20 03 58

Remove unnecessary negattive margins on the block toolbar.
These were only included in focus mode, and end up causing overlap with the block mover butons.

@kjellr kjellr requested a review from chrisvanpatten as a code owner Apr 22, 2019

@kjellr

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

Good catch, @draganescu! It's weird that didn't show up for me initially. 🤔

Anyway, I removed the style that was causing that in ecc932f.

@kjellr kjellr requested a review from jasmussen Apr 25, 2019

@jasmussen

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

Yep, works for me 👍 👍

Just needs a code sanity check, I suppose!

@gziolo

gziolo approved these changes Apr 26, 2019

@draganescu draganescu merged commit 3021cf6 into master Apr 26, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@draganescu draganescu deleted the update/restore-block-movers-to-focus-mode branch Apr 26, 2019

@kjellr

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

Thanks, everyone!

@youknowriad youknowriad added this to the 5.6 (Gutenberg) milestone May 13, 2019

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Restore block movers to focus mode (WordPress#15109)
* Restore block movers to focus mode.

* Remove unnecessary negattive margins on the block toolbar.

These were only included in focus mode, and end up causing overlap with the block mover butons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.