Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent block breadcrumb overlap with block movers for full/wide blocks #15112

Merged
merged 1 commit into from Apr 23, 2019

Conversation

@kjellr
Copy link
Contributor

commented Apr 22, 2019

#14145 introduced a new left-side placement for the block breadcrumb. This worked great at first, but when #15022 reintroduced the block movers for wide and full blocks, we realized that the new breadcrumb location overlapped with the block movers.

This PR is a potential fix for the overlap: it moves the block breadcrumb down slightly for full/wide blocks when the block movers are visible. It bumps right up against the block content itself, but I don't think this should actually cause any issues.

Before:

Screen Shot 2019-04-22 at 2 14 53 PM

After:

Screen Shot 2019-04-22 at 2 15 40 PM

movers-after

@kjellr kjellr requested a review from jasmussen Apr 22, 2019

@kjellr kjellr requested a review from chrisvanpatten as a code owner Apr 22, 2019

@kjellr kjellr self-assigned this Apr 22, 2019

@jasmussen

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Yep, good solution. 👍 👍

I don't see the jumpiness that shows up in your GIFs on my end, though — which is good, that jumpiness is a little weird.

Here's what I see. Master:

master

This branch:

this branch

Both of those are cool to me.


I think we should keep thinking about what to do with these hover labels, separately. Do we need them? Do they become tooltips? (Think hovering an img with a title on the web.)

@jasmussen
Copy link
Contributor

left a comment

Checks need to pass.

@kjellr

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

Thanks for the review! I'll merge in once that test is complete. I agree, it may be worth removing the block breadcrumbs entirely. I'm not convinced they're needed anymore.

I don't see the jumpiness that shows up in your GIFs on my end, though — which is good, that jumpiness is a little weird.

Tha only shows up under a really specific circumstance: if you hover over the center-to-right area of a block, activate the block breadcrumb, and then move your mouse over to the left of the block to trigger the appearance of the block movers. 🙂

@kjellr kjellr merged commit 354c1ff into master Apr 23, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@kjellr kjellr deleted the update/block-breadcrumb-position-block-movers branch Apr 23, 2019

@youknowriad youknowriad added this to the 5.6 (Gutenberg) milestone May 13, 2019

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.