Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/e2e custom taxonomies #15151

Merged
merged 5 commits into from May 7, 2019

Conversation

@Rahe
Copy link
Contributor

commented Apr 24, 2019

Description

Add End to end tests for closing #11305.

Steps I have tested

  1. Check the global Taxonomy Label
  2. Check the "Add new item" label once the panel is opened
  3. Add a Term
  4. Check the "Remove Item" label is the one expected
expect( labelNew ).not.toBeFalsy();
} );

it( 'Ensures the custom taxonomy labels are respected', async () => {

This comment has been minimized.

Copy link
@youknowriad

youknowriad Apr 25, 2019

Contributor

Any reason this is separate from the first test, it feels like something that can be included in the same test as it's a continuation, right?

This comment has been minimized.

Copy link
@Rahe

Rahe Apr 26, 2019

Author Contributor

Yes, I have modified this for one single test


/**
* Check the xpath
*/

This comment has been minimized.

Copy link
@youknowriad

youknowriad Apr 25, 2019

Contributor

There are some weird spacing errors in the comments. I think we also prefer using // for inline comments like these.

This comment has been minimized.

Copy link
@Rahe

Rahe Apr 26, 2019

Author Contributor

Fixed for "//" in my new commit :)

@youknowriad
Copy link
Contributor

left a comment

Nice test, thanks for the addition

Nicolas Juen added some commits Apr 26, 2019

Nicolas Juen
Nicolas Juen
expect( labelNew ).not.toBeFalsy();

// Open the sidebar.
await button.click();

This comment has been minimized.

Copy link
@aduth

aduth Apr 30, 2019

Member

If I understand correctly, this is to make sure that the custom taxonomy panel is expanded? Since the "Expanded" panels are remembered between page reloads, I might worry that there's a chance this could already be expanded, and proceeding to click the button would collapse the panel.

Would it be possible to check to see that the panel is not already expanded before clicking it?

This comment has been minimized.

Copy link
@Rahe

Rahe Apr 30, 2019

Author Contributor

I have check this before clicking on it, is it ok like this ?

@youknowriad
Copy link
Contributor

left a comment

LGTM 👍

@youknowriad youknowriad merged commit 9c6e062 into WordPress:master May 7, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@Rahe Rahe deleted the Rahe:test/e2e-custom-taxonomies branch May 7, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.