Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try tweaking the specificity of the custom color syntax #15167

Merged
merged 3 commits into from May 3, 2019

Conversation

@jasmussen
Copy link
Contributor

commented Apr 25, 2019

This fixes #12986 and is based on the conversation there.

Instead of doubling the selectors to increase specificity, we are supplying the element as well.

Try tweaking the specificity of the custom color syntax
This fixes #12986 and is based on the conversation there.

Instead of doubling the selectors to increase specificity, we are supplying the element as well.
@m-e-h

This comment has been minimized.

Copy link
Member

commented on packages/block-library/src/style.scss in 9132137 Apr 29, 2019

It may still be worth mentioning that the main reason for this is because link states like :hover add greater specificity.

This comment has been minimized.

Copy link
Contributor Author

replied Apr 30, 2019

Yup!

@m-e-h

This comment has been minimized.

Copy link
Member

commented on packages/block-library/src/style.scss in 9132137 Apr 29, 2019

Y u no nest? 😄

This comment has been minimized.

Copy link
Contributor Author

replied Apr 30, 2019

🤦‍♂

@jasmussen jasmussen marked this pull request as ready for review Apr 30, 2019

@jasmussen

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

Thanks for the review! Addressed the points.

@jorgefilipecosta
Copy link
Member

left a comment

LGTM 👍 The specificity is not changed so users should not notice any difference.

@jasmussen jasmussen added this to the 5.7 (Gutenberg) milestone May 3, 2019

@jasmussen jasmussen merged commit 42eb03c into master May 3, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@jasmussen jasmussen deleted the try/tweak-color-override-css branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.