Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Library: Remove secondary (access) shortcuts #15191

Merged
merged 3 commits into from Jun 7, 2019

Conversation

@ellatrix
Copy link
Member

commented Apr 25, 2019

Description

See #11154 (partial fix). Removes all access shortcuts from the format library.

It is worth noting that:

  • All primary (most used) formats (bold, italic, and link) still have primary shortcuts.
  • Strikethrough and code are present in the UI, so they can both be accessed with the keyboard and pointer device.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ellatrix ellatrix added this to the 5.6 (Gutenberg) milestone Apr 25, 2019

@ellatrix ellatrix requested a review from afercia Apr 25, 2019

@ellatrix ellatrix force-pushed the remove/secondary-format-shortcuts branch from be3116d to 9ec26f6 May 1, 2019

@ellatrix ellatrix requested review from ajitbohra, gziolo, nerrad and ntwb as code owners May 1, 2019

@jorgefilipecosta
Copy link
Member

left a comment

The changes look good to me from the code point of view 👍

@gziolo gziolo removed this from the 5.6 (Gutenberg) milestone May 6, 2019

@gziolo

This comment has been minimized.

Copy link
Member

commented May 23, 2019

This PR needs rebase and should be merged afterward :)

@ellatrix ellatrix force-pushed the remove/secondary-format-shortcuts branch from 9ec26f6 to 7320056 Jun 6, 2019

@ellatrix ellatrix merged commit 2d66c59 into master Jun 7, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@ellatrix ellatrix deleted the remove/secondary-format-shortcuts branch Jun 7, 2019

@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019

nicolad added a commit to nicolad/gutenberg that referenced this pull request Jun 15, 2019

Format Library: Remove secondary (access) shortcuts (WordPress#15191)
* Format Library: Remove secondary (access) shortcuts

* Update help modal

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.