Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Library: Code => Inline Code #15199

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
3 participants
@ellatrix
Copy link
Member

commented Apr 25, 2019

Description

This PR renames the "Code" format to "Inline Code" to avoid confusing with the block "Code". This is similar to how we named the image format "Inline Image", because there is also an "Image" block.

Also removes some duplicate translations.

How has this been tested?

Screenshots

Schermafbeelding 2019-04-25 om 22 36 27

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@jorgefilipecosta
Copy link
Member

left a comment

LGTM 👍

@ellatrix

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

Thanks!

@ellatrix ellatrix merged commit 8f0cb51 into master May 2, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@ellatrix ellatrix deleted the rename/inline-code branch May 2, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.