Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove aria-label from block inserter list item #15382
Removed an aria-label that was flagged as unnecessary in item WUT-18 of the WPCampus accessibility audit. Fixes #15337.
In my opinion, if the aria-label makes it work in IE11/Jaws that should override the potential issue brought up in the audit and it should stay.
How has this been tested?
Tested with Apple VoiceOver on a Mac and it still reads out the button text correctly when navigated to with the keyboard.
Types of changes
Bug fix (non-breaking change which fixes an issue)
requested review from
May 1, 2019
gziolo left a comment •
It looks like a big number of e2e tests depend on the
referenced this pull request
May 6, 2019
Hey @brentswisher, it looks like you might have pushed a branch
Not sure how it happened
That's weird, I have no idea where that came from or how I managed to get it in the main Gutenberg repo! It's obviously a typo of some kind on my part, but I don't seem to have permission to delete it. If you could remove it and hide my shame from the world @talldan it would be much appreciated!
May 9, 2019
@gziolo I've added fixes for the end-to-end tests. All the tests pass now, but I haven't worked with the e2e test suite much before, so a review would be very appreciated to see if there is a better way to do this :)
I contemplated refactoring into a 'clickBlockInserterButton' utility, but most tests use insertBlock anyways so it seemed a little overkill.
The third commit fixes an issue in block-hierarchy-navigation.test.js, but I am not sure if that is related to my changes or not. I was experiencing it intermittently locally on my master branch as well, but it consistently happened in my new branch.
I watched the test run in non-headless mode to see what was happening and it...passed. I watched again without slowmo enabled and it appeared the space was getting clicked before the block navigation opened. I wasn't sure if I should open another issue or commit it here, but hopefully that gives some background at least.