Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role to the copy all content menu item #15383

Merged

Conversation

Projects
None yet
3 participants
@brentswisher
Copy link
Contributor

commented May 2, 2019

Description

Adds the appropriate role="menuitem" to the 'Copy all Content' button in the editor menu. Item GUT-67 in the WPCampus accessibility audit.

Fixes #15336

How has this been tested?

Inspect menu source, verify menu item role is present. Navigate the menu with VoiceOver on a Mac and verify it announces as a menu item when navigated to.

Screenshots

Fullscreen_5_1_19__8_07_PM

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
Add role to the copy all content menu item
It was previously only being reported as a button to
screen readers, item GUT-67 of the WPCampus
accessibility audit.

@gziolo gziolo added this to the 5.7 (Gutenberg) milestone May 4, 2019

@gziolo gziolo merged commit 03c5856 into WordPress:master May 4, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.