Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #15386

Merged
merged 3 commits into from May 2, 2019

Conversation

Projects
None yet
3 participants
@andreyc0d3r
Copy link
Contributor

commented May 2, 2019

This is a very nasty gotcha that can suck out hours from your day.

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
Update README.md
This is a very nasty gotcha that can suck out hours from your day.
@talldan

talldan approved these changes May 2, 2019

Copy link
Contributor

left a comment

Thanks for the PR @andreyc0d3r! I'm pretty happy with the change, though I left a few suggestions to make it even more noticable.

talldan and others added some commits May 2, 2019

Update packages/block-editor/src/components/inner-blocks/README.md
Co-Authored-By: andreyc0d3r <andreyc0d3r@gmail.com>
Update packages/block-editor/src/components/inner-blocks/README.md
Co-Authored-By: andreyc0d3r <andreyc0d3r@gmail.com>

@talldan talldan merged commit b36a56d into WordPress:master May 2, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@andreyc0d3r andreyc0d3r deleted the andreyc0d3r:patch-1 branch May 3, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.