Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: DateTimePicker styles don't load as expected outside WordPress context #15389

Conversation

@jorgefilipecosta
Copy link
Member

commented May 2, 2019

Closes: #8870

I started this PR with the objective of closing #8870 which is a very old issue. Meanwhile, I noticed the arrow styles referenced on the issue were already fixed, but the component still had some styling problems outside WordPress this PR fixes these problems.

Before:
image

After:
image

How has this been tested?

I pasted the following gist https://gist.github.com/jorgefilipecosta/6e55059202ccbcb683a56f0546ea6f93 on playground/src/index.js.
I executed the playground and verified the DateTimePicker component appears with the same look as it appears inside WordPress context e.g: the post scheduler.

@jorgefilipecosta jorgefilipecosta merged commit 2f4a6f1 into master Jun 3, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/datetimepicker-component-styles-dont-load-as-expected branch Jun 3, 2019

@jorgefilipecosta

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

Hi @aduth I tried to removed the input styles, and the result was unexpected:
Screenshot 2019-06-03 at 10 59 44

So I decided to keep them if I missed something feel free to comment, and I will open a follow-up PR.

@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019

nicolad added a commit to nicolad/gutenberg that referenced this pull request Jun 15, 2019

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.