Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Header text scale is inconsistent between classic and heading block #15393

Merged
merged 1 commit into from May 7, 2019

Conversation

@jorgefilipecosta
Copy link
Member

commented May 2, 2019

Fixes: #8373

The classic blocks styles specified styles for the headings, this made the text scale inconsistent with the styles used for header blocks that normally use theme styles.

This PR removes the style changes applied to headings by the classic block.

How has this been tested?

I used the "Twenty Fourteen", "Twenty Seventeen", and "Twenty Nineteen" themes and verified the heading styles were the same for headings on the classic block and for headings on the header block.

Screenshots

Screenshot 2019-05-02 at 13 36 58

@jasmussen
Copy link
Contributor

left a comment

Yep! Thank you. A good clean fix that I can confirm is working as intended in my testing. Doesn't preclude further fixes to rounding the header values, but it's a good step forward.

@jorgefilipecosta jorgefilipecosta merged commit ea18780 into master May 7, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/header-text-scale-is-inconsistent branch May 7, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.