Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Block Editor instead of Gutenberg when appropriatte in the Handbook #15411

Merged
merged 20 commits into from May 3, 2019

Conversation

@nosolosw
Copy link
Member

commented May 3, 2019

The current thinking is that Gutenberg should be used for the project itself, and BlockEditor for the first product of this project.

@nosolosw nosolosw referenced this pull request May 3, 2019

Merged

Add a DevHub manifest #15254

4 of 4 tasks complete

@nosolosw nosolosw self-assigned this May 3, 2019

@nosolosw nosolosw marked this pull request as ready for review May 3, 2019

@mkaz

mkaz approved these changes May 3, 2019

Copy link
Member

left a comment

Looks good, just added the casing for block editor will approve assuming you accept 👍

@chrisvanpatten

This comment has been minimized.

Copy link
Member

commented May 3, 2019

My feedback echoes @mkaz — lowercase block editor makes more sense based on previous discussions in terms of how we use "Classic Editor" vs "classic editor".

@nosolosw nosolosw force-pushed the update/docs-gutenberg-to-block-editor branch from 6ce3f49 to 45d38a5 May 3, 2019

@nosolosw

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

Had to rebase from master to address some changes and lost @mkaz's suggestions that I had commited using GitHub's UI. I hope I applied everything in cdbf930. Please, let me know if you notice something that's not fixed.

@chrisvanpatten

This comment has been minimized.

Copy link
Member

commented May 3, 2019

@nosolosw In the interest of avoiding future rebases I say 🚢 and we can address more cases in a follow-up if needed!

@nosolosw nosolosw merged commit 0ad0414 into master May 3, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@nosolosw nosolosw deleted the update/docs-gutenberg-to-block-editor branch May 3, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.