Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Server side rendered blocks are not parsed on the widgets screen. #15414

Conversation

Projects
None yet
2 participants
@jorgefilipecosta
Copy link
Member

commented May 3, 2019

Description

Server-side rendered blocks are not being correctly parsed on widgets screen making legacy widget blocks not load correctly on #15074.
The problem was that the server side block definitions were not being bootstrapped on the widgets page.

How has this been tested?

I went to the widgets page http://yah.local/wp-admin/admin.php?page=gutenberg-widgets.
I pasted wp.blocks.parse('<!-- wp:latest-posts {"postsToShow":34,"displayPostDate":true} /-->');on the developer tools command line.
I verified the attributes were correctly parsed on the return value.

@youknowriad
Copy link
Contributor

left a comment

Seems legit

@jorgefilipecosta jorgefilipecosta merged commit a90752e into master May 6, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/server-side-rendered-blocks-not-parsed-on-the-widgets-screen branch May 6, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.