Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate doc generation and fix next/prev links issue #15421

Merged
merged 7 commits into from May 4, 2019

Conversation

@nosolosw
Copy link
Member

commented May 3, 2019

This Pull Request seeks to address two issues:

  • #14794 by modifying how the data docs are regenerated we fix the next/previous links for the data section.
  • #14227 See first task: update handbook to use docgen.

Depends on:

  • #15423 so those symbols are not added to the docs.
  • #15424 these symbols will be added back to docs with this PR, linking to the proper core/block-editor symbol.
@chrisvanpatten
Copy link
Member

left a comment

I wish there was more that could be done here to abstract some of this (so the docs tooling doesn't need to have specific package names and such hard-coded in) but given the amount of work likely required to accomplish that, this seems like a perfectly practical path forward.

@nosolosw nosolosw force-pushed the update/handbook-data-docs branch from ae81eca to e2ff3c7 May 3, 2019

@nosolosw nosolosw merged commit 4adbe72 into master May 4, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@nosolosw nosolosw deleted the update/handbook-data-docs branch May 4, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.