Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for selectors & actions moved to block-editor #15424

Merged
merged 5 commits into from May 3, 2019

Conversation

@nosolosw
Copy link
Member

commented May 3, 2019

In #13088 we moved some actions and selectors to the block-editor package. This had the secondary effect of removing them from the handbook docs.

They'll be brought back to the handbook in #15421 but to avoid an immense PR difficult to review I'd like to merge this change first.

Test

Check that there are no changes in documentation just yet.

npm run docs:build

nosolosw added some commits May 3, 2019

Ignore actions that do not have a description.
This is to avoid adding any symbols to the generated handbook docs just yet.
We'll add them back when switching to the new system.
export const resetBlocks = getBlockEditorAction( 'resetBlocks' );
/**

This comment has been minimized.

Copy link
@chrisvanpatten

chrisvanpatten May 3, 2019

Member

These all look great but from a code standards/ bike sheddy perspective I just wonder if we should have newlines above all these, similar to how it'd be done in PHP doc?

This comment has been minimized.

Copy link
@nosolosw

nosolosw May 3, 2019

Author Member

let's do that d1b7aff

@nosolosw nosolosw requested a review from chrisvanpatten May 3, 2019

@nosolosw nosolosw merged commit b371259 into master May 3, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@youknowriad youknowriad deleted the update/docs-editor-selectors-actions branch May 6, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.