Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack dependency plugin: Fix filename function handling #15430

Merged
merged 3 commits into from May 6, 2019
Merged

Webpack dependency plugin: Fix filename function handling #15430

merged 3 commits into from May 6, 2019

Commits on May 4, 2019

  1. Add failing test for #15410

    @sirreal
    sirreal committed May 4, 2019
    Copy the full SHA
    0aa5dc9 View commit details
    Browse the repository at this point in the history

  2. Move .js to .deps.json replacement to path result 

    Replacement in the output.filename template works fine with a string
filename. However, webpack also accepts a function filename, which
causes errors when the replacement is attempted.

Move the replacement to the result of `getPath`, when we should reliably
have a string.

Fixes #15410
    @sirreal
    sirreal committed May 4, 2019
    Copy the full SHA
    97aa93e View commit details
    Browse the repository at this point in the history

  3. Add fixed test snapshot

    @sirreal
    sirreal committed May 4, 2019
    Copy the full SHA
    3d98691 View commit details
    Browse the repository at this point in the history