Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Reinstate correct cover block attributes for deprecations #15449
The incorrect attributes were specified in the
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
requested review from
May 6, 2019
referenced this pull request
May 6, 2019
It would be awesome. When you have HTML markup, you just need to put it in the proper folder following the pattern used for other files. Then you run
@gziolo I've added one for the latest deprecation, but there are a couple of older ones still. Is it worth going back through all the past deprecations for the cover block and adding those too? If so, would the idea be to add the markup to the same
In #15268 @ellatrix suggested to include new file per deprecation entry, so let's try to do it here as well. I think, you will have to use
@gziolo Wasn't straightforward getting markup for the older deprecations, just about managed it.
I've added those fixtures the way we discussed. If another deprecation is added, all someone has to do is add a