Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverts the rename of postsToShow as it may cause breaking changes #15453

Merged
merged 3 commits into from May 6, 2019

Conversation

@draganescu
Copy link
Contributor

commented May 6, 2019

Description

#14627 renamed postsToShow to postCount on my suggestion in the latest posts block. This reverts that as I didn't consider that is a breaking change. It could be renamed still but the effor to write the deprecation code is not justified.

How has this been tested?

Local testing of the latest posts code

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
@@ -135,7 +135,7 @@ function register_block_core_latest_posts() {
'categories' => array(
'type' => 'string',
),
'postCount' => array(
'postsToShow' => array(

This comment has been minimized.

Copy link
@gziolo

gziolo May 6, 2019

Member

phpcs will complain, spaces need to align with other fields

@gziolo

gziolo approved these changes May 6, 2019

Copy link
Member

left a comment

@draganescu, thanks for working on it. This is ready to merge once Travis is happy.

draganescu added some commits May 6, 2019

@draganescu draganescu merged commit d8f1875 into master May 6, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@draganescu draganescu deleted the fix/revert-rename-in-latest-posts branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.