Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix next/previous links in handbook #15456

Merged
merged 2 commits into from May 6, 2019

Conversation

@nosolosw
Copy link
Member

commented May 6, 2019

Closes #14794

After landing #15421 the only outstanding issue for next/previous links were components and packages children. This fixes the issue by embedding the sections in the proper places.

@chrisvanpatten
Copy link
Member

left a comment

All the changes to the tooling code look good, just want to make sure we still target manifest-devhub.json for the moment, to avoid unintentional changes on the legacy handbook until the auto-updates are disabled and the bulk redirects are on.

"slug": "theme-support",
"markdown_source": "https://raw.githubusercontent.com/WordPress/gutenberg/master/docs/designers-developers/developers/themes/theme-support.md",
"parent": "themes"
"title": "@wordpress/a11y",

This comment has been minimized.

Copy link
@chrisvanpatten

chrisvanpatten May 6, 2019

Member

The legacy manifest.json should not be changing at this point, so the legacy handbook isn't updated. Updated manifests should still be targeted at manifest-devhub.json until we can disable the auto-updates at the legacy handbook.

This comment has been minimized.

Copy link
@nosolosw

nosolosw May 6, 2019

Author Member

Note that the changes merely reorder the sections to fix the previous/next links, do not alter anything else (titles, slug, etc). This can be safely merged, then the DevHub manifest PR can be rebased and updated to reflect these changes as well.

const { getRootManifest } = require( './manifest' );

const tocFileInput = path.resolve( __dirname, '../toc.json' );
const manifestOutput = path.resolve( __dirname, '../manifest.json' );

This comment has been minimized.

Copy link
@chrisvanpatten

chrisvanpatten May 6, 2019

Member

See note above re: manifest.json vs manifest-devhub.json

@chrisvanpatten
Copy link
Member

left a comment

:shipit:

@nosolosw nosolosw merged commit eab4739 into master May 6, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@nosolosw nosolosw deleted the fix/next-prev-links branch May 6, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.