Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility on missing block #15457

Merged
merged 5 commits into from May 10, 2019

Conversation

Projects
None yet
3 participants
@koke
Copy link
Contributor

commented May 6, 2019

@etoledom
Copy link
Contributor

left a comment

Thank you @koke for improving Accessibility 🎉

I added a couple of comments, but it's working great!

Show resolved Hide resolved packages/block-library/src/missing/edit.native.js Outdated
Show resolved Hide resolved packages/block-library/src/missing/edit.native.js Outdated

etoledom and others added some commits May 7, 2019

Update packages/block-library/src/missing/edit.native.js
Co-Authored-By: koke <jbernal@gmail.com>
Remove unnecessary dot for accessibility label
Co-Authored-By: koke <jbernal@gmail.com>
@etoledom
Copy link
Contributor

left a comment

Thank you for the update!
Feel free to :shipit: when from CI

koke added some commits May 7, 2019

@koke koke merged commit 94d48e0 into master May 10, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@koke koke deleted the rnmobile/a11y-unsupported branch May 10, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.