Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/buttons should not appear as links #15460

Merged
merged 4 commits into from May 13, 2019

Conversation

@getdave
Copy link
Contributor

commented May 6, 2019

Description

Closes #15358 (comment).

Addresses issue from a11y report by removing link styling from buttons elements within the prepublish sidebar.

How has this been tested?

  • Open prepublish sidebar
  • Verify the button text is not styled to visually appear as a link (eg: underlined and blue color)

Screenshots

Screen Shot 2019-05-06 at 15 42 55

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@jorgefilipecosta
Copy link
Member

left a comment

Works as expected 👍

font-weight: 400;
padding-left: 4px;
text-decoration: underline;
text-decoration: none;

This comment has been minimized.

Copy link
@jorgefilipecosta

jorgefilipecosta May 6, 2019

Member

Minor: I guess given that the element is a span, we don't need to add text-decoration: none; and we can just remove text-decoration: underline;.

This comment has been minimized.

Copy link
@kjellr

kjellr May 7, 2019

Contributor

Agreed, this PR works fine with the text-decoration rule deleted. 👍

@kjellr

kjellr approved these changes May 7, 2019

Copy link
Contributor

left a comment

This works for me!

Screen Shot 2019-05-07 at 9 20 15 AM

I agree with @jorgefilipecosta's note about the text-decoration rule, but once that's removed this should be good to merge in. 👍

Thanks!

font-weight: 400;
padding-left: 4px;
text-decoration: underline;
text-decoration: none;

This comment has been minimized.

Copy link
@kjellr

kjellr May 7, 2019

Contributor

Agreed, this PR works fine with the text-decoration rule deleted. 👍

@afercia

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Looks good from an a11y perspective, thanks for the PR! As already noted, text-decoration: none; seems redundant.

@getdave getdave merged commit 6171097 into master May 13, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@youknowriad youknowriad deleted the fix/buttons-should-not-appear-as-links branch May 13, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.