Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update save indicator contrast to pass AA #15514

Merged
merged 1 commit into from May 9, 2019
Merged

Update save indicator contrast to pass AA #15514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/editor/src/components/post-saved-state/style.scss
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@
align-items: center;
width: $icon-button-size - 8px;
padding: #{ $grid-size-small * 3 } $grid-size-small;
color: $light-gray-900; // Doesn't need to meet AA because button is disabled and it's supporting text.
color: $dark-gray-500;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use $dark-gray-300 if you like. That also meets AA contrast.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — I just tried this out, but I think we should stick with $dark-gray-500 for now. $dark-gray-300 adds another gray shade to the toolbar, and I think the hierarchy is more straightforward if we keep the color palette limited there.

overflow: hidden;
white-space: nowrap;

Expand Down