Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix menu item colors #15531
This PR fixes an inconsistency in menu item colors. There were some redundant CSS that had not been cleaned up properly with the move to the color mixins.
Additionally it replaces the use of opacity for the lighter text in the menus, and uses the color variables instead, as those colors do not need to work on differently colored backgrounds, just white.
requested review from
May 9, 2019
It can be a crapshoot sometimes when, in a mixin, you define a color without also defining the background-color.
A more predictable and cleaner approach might be to define the color where we're defining the background for both of these components, on