Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus color contrast #15544

Merged
merged 4 commits into from May 10, 2019

Conversation

@truchot
Copy link
Contributor

commented May 9, 2019

In order to fix my Pull Request #15535

Fixes #15432 & fixes #15325

Description

Fix low contrast color when button or input are focus as mentioned in #15432 & #15325
I choose $blue-medium-focus color for more consistency

Screenshots

localhost_8888_wp-admin_post php_post=1 action=edit (2)

localhost_8888_wp-admin_post php_post=1 action=edit (3)

localhost_8888_wp-admin_post php_post=7 action=edit

@truchot truchot referenced this pull request May 9, 2019

Closed

Fix color focus styles #15535

@truchot truchot changed the title Fix/focus color contrast Fix focus color contrast May 9, 2019

@youknowriad youknowriad requested review from jasmussen and kjellr May 10, 2019

@jasmussen
Copy link
Contributor

left a comment

Thank you for the pull request. This is nice work.

I think it's worth looking at buttons in general, and in the context of all of WordPress, in a unified effort to improve legebility even outside of the editor alone. This is what's somewhat suggested in this comment.

I think we should absolutely do that still, and we might have to revisit these focus style as we do so.

However in the mean time, such a future effort should not block improvements from happening today. In that vein, this is a nice improvement.

@truchot

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

Thanks a lot !

I agree maybe the next step is to harmonize button style. In any case, I can continue improving the buttons appearance in other PR ?

@jasmussen

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

I can continue improving the buttons appearance in other PR ?

Thanks for the offer. I think the next step requires a little more in-depth design thinking, and they have to consider buttons outside of the editor as well, i.e. the rest of WordPress. So a PR wouldn't be technically possible here, as the rest is in SVN.

@youknowriad youknowriad merged commit 5746ac3 into WordPress:master May 10, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019

@afercia

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

@truchot thanks very much for your PR 🎉

@jasmussen yep, I think the best place to improve the core buttons is:

The design of the focus outline on buttons/elements could be improved
https://core.trac.wordpress.org/ticket/34904

Any help from the Gutenberg and design team to help that ticket move on would be greatly appreciated.

@afercia

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

Worth noting the links styled as buttons (e.g. "Preview") have a focus style only in Chrome. As noted in #13267 seems only Chrome understands :focus:enabled on a link. Firefox, Safari, Edge, and IE 11, don't. As focus style is greatly improved by this PR but a pre-existing issue prevents focus style from being visible on link-buttons, I'm going to move #13267 to the Accessibility Audit project, in the "To do" lane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.