Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix focus color contrast #15544
requested review from
May 9, 2019
jasmussen left a comment
Thank you for the pull request. This is nice work.
I think it's worth looking at buttons in general, and in the context of all of WordPress, in a unified effort to improve legebility even outside of the editor alone. This is what's somewhat suggested in this comment.
I think we should absolutely do that still, and we might have to revisit these focus style as we do so.
However in the mean time, such a future effort should not block improvements from happening today. In that vein, this is a nice improvement.
Thanks for the offer. I think the next step requires a little more in-depth design thinking, and they have to consider buttons outside of the editor as well, i.e. the rest of WordPress. So a PR wouldn't be technically possible here, as the rest is in SVN.
May 10, 2019
1 check passed
referenced this pull request
May 10, 2019
@truchot thanks very much for your PR
@jasmussen yep, I think the best place to improve the core buttons is:
The design of the focus outline on buttons/elements could be improved
Any help from the Gutenberg and design team to help that ticket move on would be greatly appreciated.
Worth noting the links styled as buttons (e.g. "Preview") have a focus style only in Chrome. As noted in #13267 seems only Chrome understands