Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use block-editor instead of editor in cover block. #15547

Merged
merged 1 commit into from May 10, 2019

Conversation

@jorgefilipecosta
Copy link
Member

commented May 9, 2019

Description

These dependencies should have been updated. Blocks should not use the editor dependency directly as for example in the widget screen and the playground editor will not be available.

How has this been tested?

I did some smoke testing in the cover block.
I pasted the following code:

const {
	BlockControls,
	BlockIcon,
	InnerBlocks,
	InspectorControls,
	MediaPlaceholder,
	MediaUpload,
	MediaUploadCheck,
	PanelColorSettings,
	withColors,
} = wp.blockEditor;
const ok = {
	BlockControls,
	BlockIcon,
	InnerBlocks,
	InspectorControls,
	MediaPlaceholder,
	MediaUpload,
	MediaUploadCheck,
	PanelColorSettings,
	withColors,
};
ok;

I verified that all properties are defined.

@gziolo

gziolo approved these changes May 10, 2019

Copy link
Member

left a comment

Looks good 👍

@jorgefilipecosta jorgefilipecosta merged commit f723d02 into master May 10, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/update-cover-block-dependencies branch May 10, 2019

@gziolo

This comment has been minimized.

@gziolo

This comment has been minimized.

Copy link
Member

commented May 10, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.