Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text warning about usability when autoplay is selected #15575

Merged

Conversation

@brentswisher
Copy link
Contributor

commented May 10, 2019

Description

Add the following as help text on the toggles for autoplay for both audio and video blocks:
"Note: Autoplaying [media type] may cause usability issues for some visitors."

Fixes #13550

How has this been tested?

Added an audio block and video block
Toggle autoplay and see that the appropriate text is displayed when it is toggled

Screenshots

JxHXwG76ct
(Note: screenshot has a typo in video message that has been fixed)

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@gziolo

gziolo approved these changes May 13, 2019

Copy link
Member

left a comment

Code wise this change looks good 👍

@gziolo gziolo merged commit 1d82701 into WordPress:master May 13, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.