Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Moving native tests to gutenberg repo #15589

Merged
merged 15 commits into from Jun 4, 2019

Conversation

Projects
None yet
4 participants
@etoledom
Copy link
Contributor

commented May 13, 2019

gutenberg-mobile side PR: wordpress-mobile/gutenberg-mobile#977

This PR moves some of the mobile-gutenberg test suits to the gutenberg repo.
Added an exception to test/unit/jest.config.js so these tests are not run by npm run test-unit.

As a intermediate step, these tests will continue to be run only from gutenberg-mobile checkout via yarn test.

On a next step we plan to integrate these mobile tests to the gutenberg tool-chain.

To test:

  • On a stand-alone checkout of gutenberg run rpm run test-unit
  • Check that none of these new tests are run.
  • Check that all tests pass.

etoledom added some commits May 15, 2019

Rename native tests folder from __native_tests__ to test
To be able to use the same structure already in place.
expect( component.exists() ).toBe( true );
} );

it( 'splits empty block on Enter', () => {

This comment has been minimized.

Copy link
@koke

koke May 15, 2019

Contributor

Minor nitpick, specially since I think this is just a file move, but since there's no actually Enter keypress involved in this test, I wouldn't mention it on the test name

This comment has been minimized.

Copy link
@etoledom

etoledom May 20, 2019

Author Contributor

Nice catch! Removed the reference to "on Enter".

@etoledom etoledom requested review from koke and hypest May 20, 2019

@etoledom etoledom changed the title [Mobile] (WIP) Moving native tests to gutenberg repo (WIP) Moving native tests to gutenberg repo May 20, 2019

[Mobile] Add unit tests for willTrimSpaces function in RichText (#15552)
* Add unit test for willTrimSpaces.

* Fix willTripSpaces to report false for no outer spaces on styled text.

* Ignore gutenberg-mobile unit tests in gutenberg test pipeline

* Revert "Fix willTripSpaces to report false for no outer spaces on styled text."

This reverts commit 0731689.

Upstream changes make this implementation no longer necessary.

* Fix lint issues

* Import RichText without native extension

* Remove stubs from rich-text __mocks__

@etoledom etoledom changed the title (WIP) Moving native tests to gutenberg repo [RNMobile] Moving native tests to gutenberg repo May 23, 2019

@koke

koke approved these changes Jun 4, 2019

Copy link
Contributor

left a comment

Looks good to me 👏

@etoledom etoledom merged commit 1a293b3 into master Jun 4, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@etoledom etoledom deleted the rnmobile/move-mobile-tests-to-gutenberg-repo branch Jun 4, 2019

@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019

nicolad added a commit to nicolad/gutenberg that referenced this pull request Jun 15, 2019

[RNMobile] Moving native tests to gutenberg repo (WordPress#15589)
* Moving paragraph native test to gutenberg repo

* Rename native tests folder from __native_tests__ to test
To be able to use the same structure already in place.

* Ignore .native.js files on unit tests

* Move native code block test to gutenberg repo.

* Moved native link modal tests to gutenberg repo

* Moved mobile media progress tests to gutenberg repo.

* Moved mobile media upload tests to gutenberg repo

* Renamed mobile paragraph block tests to be the same as the file it tests

* [Mobile] Add unit tests for willTrimSpaces function in RichText (WordPress#15552)

* Add unit test for willTrimSpaces.

* Fix willTripSpaces to report false for no outer spaces on styled text.

* Ignore gutenberg-mobile unit tests in gutenberg test pipeline

* Revert "Fix willTripSpaces to report false for no outer spaces on styled text."

This reverts commit 0731689.

Upstream changes make this implementation no longer necessary.

* Fix lint issues

* Import RichText without native extension

* Remove stubs from rich-text __mocks__

* Update native paragraph test

* Update mobile link tests

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

[RNMobile] Moving native tests to gutenberg repo (WordPress#15589)
* Moving paragraph native test to gutenberg repo

* Rename native tests folder from __native_tests__ to test
To be able to use the same structure already in place.

* Ignore .native.js files on unit tests

* Move native code block test to gutenberg repo.

* Moved native link modal tests to gutenberg repo

* Moved mobile media progress tests to gutenberg repo.

* Moved mobile media upload tests to gutenberg repo

* Renamed mobile paragraph block tests to be the same as the file it tests

* [Mobile] Add unit tests for willTrimSpaces function in RichText (WordPress#15552)

* Add unit test for willTrimSpaces.

* Fix willTripSpaces to report false for no outer spaces on styled text.

* Ignore gutenberg-mobile unit tests in gutenberg test pipeline

* Revert "Fix willTripSpaces to report false for no outer spaces on styled text."

This reverts commit 0731689.

Upstream changes make this implementation no longer necessary.

* Fix lint issues

* Import RichText without native extension

* Remove stubs from rich-text __mocks__

* Update native paragraph test

* Update mobile link tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.