Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken active state on formatting buttons #15592

Merged
merged 1 commit into from May 13, 2019

Conversation

@jasmussen
Copy link
Contributor

commented May 13, 2019

At some point recently a small regression was introduced to the formatting button styles where the :active state box shadow that is inherited from the IconButton component lingered. To reproduce in master, click and drag out while holding the mouse button down on a formatting button and note a gray box shadow lingering. This PR fixes that.

I'm unsure as to how the regression was introduced, but it was likely due to the rather long selectors the IconButton component uses, which would be good to refactor.

Before:

Screenshot 2019-05-13 at 11 51 33

After:

Screenshot 2019-05-13 at 11 45 26

Fix broken active state on formatting buttons
At some point recently a small regression was introduced to the formatting button styles where the `:active` state box shadow that is inherited from the IconButton component lingered. To reproduce in master, click and drag out on a formatting button and note a gray box shadow lingering. This PR fixes that.

I'm unsure as to how the regression was introduced, but it was likely due to the rather long selectors the IconButton component uses, which would be good to refactor.
@gziolo

gziolo approved these changes May 13, 2019

@jasmussen

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

Wow nice, fast work! I'll merge when the checks pass.

@jasmussen jasmussen merged commit eea04cf into master May 13, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@jasmussen jasmussen deleted the fix/formatting-regression branch May 13, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.