Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Fixed links as buttons focus state. #15601

Merged

Conversation

@nicolad
Copy link
Contributor

commented May 13, 2019

Description

Fixes: #13267

How has this been tested?

To reproduce:

  • use a keyboard
  • tab to the "Preview" button (it's a link)
  • in Chrome, there's a subtle focus style
  • in Firefox, Safari, Edge, IE11 there's no focus style

It should work properly from now on.

Types of changes

Changed &:focus:enabled to &:focus:not(:disabled).

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@gziolo

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@nicolad - you can start opening PRs through Gutenberg repository since you are a member:
Screen Shot 2019-05-14 at 11 23 27

:)

@gziolo

This comment has been minimized.

Copy link
Member

commented May 14, 2019

I can confirm it works now in both FF and Safari:

Screen Shot 2019-05-14 at 12 05 54

@gziolo

gziolo approved these changes May 14, 2019

Copy link
Member

left a comment

@nicolad thanks for fixing 👍

@gziolo gziolo merged commit bbb37b1 into WordPress:master May 14, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.