Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Clarify migrate in deprecated blocks #15612

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
3 participants
@mkaz
Copy link
Member

commented May 13, 2019

Description

The wording in migrate was confusing around which attributes should be
supplied and returned. Added old/new to clarify the old attributes are
passed in, and new attributes are returned.

Confirmed this with the code, which you can see in the test here:
https://github.com/WordPress/gutenberg/blob/master/packages/blocks/src/api/test/parser.js#L558

Fixes #15111

Types of changes

Documentation. View on branch here.

Docs: Clarify migrate in deprecated blocks
The wording in migrate was confusing around which attributes should be
supplied and returned. Added old/new to clarify the old attributes are
passed in, and new attributes are returned.

Confirmed this with the code, which you can see in the test here:
https://github.com/WordPress/gutenberg/blob/master/packages/blocks/src/api/test/parser.js#L558
@jorgefilipecosta
Copy link
Member

left a comment

LGTM 👍

@mkaz mkaz merged commit b695b53 into master May 13, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@mkaz mkaz deleted the docs/15111/deprecated branch May 13, 2019

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.