Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Interaction: always reset initial vertical position rect #15624

Merged
merged 4 commits into from May 14, 2019

Conversation

@ellatrix
Copy link
Member

commented May 14, 2019

Description

Alternative to #15607.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
await page.keyboard.type( '2' );
await page.keyboard.press( 'ArrowUp' );
await page.keyboard.press( 'ArrowUp' );
await page.keyboard.type( 'x' ); // Should be right after "1".

This comment has been minimized.

Copy link
@ellatrix

ellatrix May 14, 2019

Author Member

@aduth Here, your PR #15607 will position the "x" before "1", because the initial position is not remembered.

@youknowriad
Copy link
Contributor

left a comment

This seems to fix the issue for me.

@ellatrix ellatrix force-pushed the fix/15604-vertical-nav-h-offset-alt branch from f11bca3 to fff3aed May 14, 2019

@aduth

aduth approved these changes May 14, 2019

Copy link
Member

left a comment

I'd wonder if there's a different basis (e.g. selection changes) we should be using for determining whether to reset this value other than specific user interactions, which seem more error-prone to try to cover (e.g. selection changes by taps, selections or field values changing programmatically).

In the interim, this seems like the most direct fix to the original issue 👍 In some stress testing, I think it may also help resolve some cases where they may have been buggy even in the original implementation (e.g. accounting for Home or End keys in selection changes).

@youknowriad youknowriad merged commit 9683d00 into master May 14, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@youknowriad youknowriad deleted the fix/15604-vertical-nav-h-offset-alt branch May 14, 2019

ellatrix added a commit that referenced this pull request May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.