Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Page Break" icon with a Material version #15627

Merged
merged 1 commit into from May 14, 2019

Conversation

@kjellr
Copy link
Contributor

commented May 14, 2019

The current "Page Break" block icon appears to be based on the "Pages" Gridicon. For greater consistency as we expand into more blocks that use a "page" icon, we should source from either Material or Dashicons. To that end, this PR replaces the page break icon with one based on the "File" icon from Material.


Before:

Screen Shot 2019-05-14 at 8 53 35 AM

After:

Screen Shot 2019-05-14 at 8 53 35 AM

@kjellr kjellr requested review from jasmussen and mapk May 14, 2019

@kjellr kjellr self-assigned this May 14, 2019

@kjellr kjellr changed the title Replace "Page Break icon with a Material version. Replace "Page Break" icon with a Material version May 14, 2019

@jasmussen
Copy link
Contributor

left a comment

Wow. Way better. It actually looks like a page broken in two.

@kjellr kjellr merged commit 94d311c into master May 14, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 14, 2019

@youknowriad youknowriad deleted the update/nextpage-icon branch May 14, 2019

@Soean

Soean approved these changes May 14, 2019

Copy link
Member

left a comment

Looks good and works in the block and inserter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.