Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Extract ServerSideRender component to an independent package #15635
ServerSideRender component was part of WordPress component. I think ServerSideRender is WordPress specific. In WordPress components, we try to keep artifacts that are generic and don't rely on WordPress API's like the rest endpoints.
In wordpress/editor we exposed a similar component that uses the WordPress components version and adds the post id as a property to be passed to the server.
WordPress/editor will not be available on the widgets screen and blocks should not rely on WordPress/editor.
We are back-compatible with usages of wp.editor.ServerSideRender.
How has this been tested?
I checked blocks using server-side render( Archives, Calendar, Lastest comments, Legacy Widgets ) still work as expected.
requested review from
May 14, 2019
May 27, 2019
added this to Genertic Block Editor Issues
in Block Editor For Widgets
May 30, 2019
referenced this pull request
Jun 3, 2019
gziolo left a comment •
There is still this unresolved indirect reference to
If this is blocking your work, feel free to merge this PR but let's make sure this discussion continues.