Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add error message from api request. #15657
Improve error message when saving posts. More detail #14644
How has this been tested?
I requested some advice on the translateability of these strings in #core-i18n yesterday, since I wasn't personally too confident about guidelines concerning the updated strings and
I just asked some follow-up questions, but it may be fine as-is. I don't think the use of
Manually repeating the steps of the test case, I can see that per the changes here, the notice also includes the error message, so the updated text query isn't enough to match the element.
I'm not very familiar with XPath, but we could update the query to query for a notice starting with the common "Updating failed." message (reference):
'//*[contains(@class, "components-notice") and contains(@class, "is-error")]/*[starts-with(text(),"Updating failed.")]'
Otherwise, just specifying the full text of the message:
'//*[contains(@class, "components-notice") and contains(@class, "is-error")]/*[text()="Updating failed. Error message: The response is not a valid JSON response."]'