Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Custom Fields option: Add confirmation step #15688
May 25, 2019
This PR shows additional message about a reload and a confirmation button to proceed. This additional UI only shows when a reload action is required and disappears when you change your mind and toggle the option back without a confirmation. It is additionally announced with spoken messages to differentiate the tickbox from all others which save options instantly.
It's not well styled and polished at this point. Let's figure out a proper interaction first.
Question: Do spoken messages make sense here? If so, what would their formulations be? I'm sure I haven't came up with the most ideal copy.
If we confirm this approach is a way forward, I can take a look at styling, making string translatable etc…
[Component] Post Settings
May 27, 2019
I can't answer the question about using
I added the
Jul 5, 2019
talldan left a comment
I had one big question about 'Save & Reload', so haven't approved this, but generally the code looks good.
I know that previously clicking the custom fields option didn't save the post, but I think the messaging now will lead to some expecting that to happen.
I believe the "save" refers to the setting. It's saving the setting and reloading the page. But it does cause confusion when the help text says that "A page reload is required" and then the button implies a "Save and load" as if referring to the page.
Maybe we can adjust the language of the button? Here are some ideas:
Any other thoughts?
Agree that adjusting the wording would be a good compromise to get this merged. I like @marekhrabe's suggestions in the comment above, or just shortening it to 'Reload' / 'Reload now'.
Could it also be worth adding something to the main part of the message? e.g. 'A page reload is required for this change, please save any changes to your content before reloading.'
Oh, I missed these. I prefer them over my suggestions. Thanks!
If handling the save of the document automatically before reloading gets tricky, this seems like the right solution. And if they miss that text and trigger the reload anyways, alerting them with an "Are you sure" message as @marekhrabe suggested works too.
I have implemented these in 8320d22
"Are you sure" functionality is done on a global level and it is already triggering for this option.
I have added an extra sentence to the info message about saved content.
With unsaved content: