Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update developer contributions link on build files notice #15697

Conversation

@arunsathiya
Copy link
Contributor

commented May 17, 2019

Description

Update developer contributions link on the Gutenberg build files notice on wp-admin (usually seen on first login).

This is to reflect the changes made in #15187 - where the developer contributions file was moved.

How has this been tested?

  • Build Gutenberg afresh and when logging in on the wp-admin for the first time, you should see the gutenberg_build_files_notice notice at the top. The contributing link should be the new one.

Screenshots

Screenshot 2019-05-17 at 14 38 32

Types of changes

  • Documentation changes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
Show resolved Hide resolved docs/contributors/readme.md Outdated
@jorgefilipecosta

This comment has been minimized.

Copy link
Member

commented May 30, 2019

Hi @arunsathiya thank you for analyzing this and bringing this subject to the discussion.
Hi @gzilo according to your comments it looks like the previous links were correct, is that the case and we can close this PR, or this there a link that still needs an update?

@gziolo

This comment has been minimized.

Copy link
Member

commented May 30, 2019

The one in gutenberg.php could still be updated as it's more accurate in the context it's displayed.

@arunsathiya

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

Somehow I lost track of this ping earlier. I'm updating the PR now to reflect that the change is required only on the build files notice.

@arunsathiya arunsathiya force-pushed the arunsathiya:update/developer-contributions-getting-started-link branch from 7b85961 to ffc523c May 30, 2019

@arunsathiya arunsathiya changed the title Update developer contributions link on build files notice and documentation Update developer contributions link on build files notice May 30, 2019

@arunsathiya

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

I have force-pushed only the change on the gutenberg.php file, and rest of the changes from earlier are removed. I have updated the PR title and description to match the current behaviour.

This is ready for one more look, @gziolo and @jorgefilipecosta.

@gziolo

gziolo approved these changes May 30, 2019

Copy link
Member

left a comment

Awesome, thanks for your first (merged) contribution to Gutenberg 🎉

@gziolo gziolo merged commit efcb62c into WordPress:master May 30, 2019

1 check failed

Travis CI - Pull Request Build Failed
Details

@gziolo gziolo added this to the 5.9 (Gutenberg) milestone May 30, 2019

@arunsathiya arunsathiya deleted the arunsathiya:update/developer-contributions-getting-started-link branch May 30, 2019

nicolad added a commit to nicolad/gutenberg that referenced this pull request Jun 15, 2019

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.