Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Fix caret position after inline paste - after selection refactor #15701

Merged
merged 5 commits into from May 30, 2019

Conversation

Projects
None yet
3 participants
@mkevins
Copy link
Contributor

commented May 17, 2019

Note

This PR is part of a series of PRs to fix the same issue. Most recently, a change in ownership of selection state has brought about an important refactor which regressed the previous PR before it was merged: #15552. The solution there is no longer viable, but the unit test in that PR may still serve as a helpful tool to prevent more regressions.

Description

This PR is intended to fix a regression of part of this issue: wordpress-mobile/gutenberg-mobile#828 , specifically, when inline content is pasted.

Companion PR.

How has this been tested?

This has been tested using the steps here:
wordpress-mobile/gutenberg-mobile#828 (comment)

Types of changes

This is a bug fix, but currently only resolves a part of the original issue. It serves as an incremental improvement. Also, this PR renames some local variables for clarity.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@Tug

Tug approved these changes May 30, 2019

Copy link
Contributor

left a comment

LGTM 👍

@mkevins mkevins merged commit 992a302 into master May 30, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@mkevins mkevins deleted the fix/caret-position-after-inline-paste3 branch May 30, 2019

@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019

nicolad added a commit to nicolad/gutenberg that referenced this pull request Jun 15, 2019

[Mobile] Fix caret position after inline paste - after selection refa…
…ctor (WordPress#15701)

* Rename variables for clarity in inline paste

* Update selection via onSelectionUpdate after inline paste

* Remove unused forceSelectionUpdate function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.