[Mobile] native mobile release v1.5.1 #15734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RichText: ownProps has precedence over block context. In this way, instances of RichText outside blocks can pass and handle their own custom onFocus and isSelected * RichText: Remove isSelected from block edit context. * Fix lint issues
Removing it generates a regression where inserting a new list block, the block is not selected
hypest
added
the
Mobile App - i.e. Android or iOS
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to add a fix for an undo issue happening in the v1.5.0 release of mobile gutenberg. Related issue: wordpress-mobile/gutenberg-mobile#1001
This PR includes the 8160f88, 0e05d0c commits too, which have already been merged to master via #15703.
Note: this is a hotfix style PR and we should not use its merged state in the mobile side release, otherwise more GB commits will be brought in. So, we'll tag and use the hash of the 7631bb1 commit but not the one that will be created after merging this PR to master.
How has this been tested?
Using this gutenberg-mobile side PR: wordpress-mobile/gutenberg-mobile#1002
Types of changes
Inhibit setting the caret position if the position is larger than the text size.
Checklist: