Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix 404 link in filters document #15836

Merged
merged 2 commits into from May 27, 2019

Conversation

@nitishkaila
Copy link
Contributor

commented May 27, 2019

Fix 404 link which is reported bug in following link.

Closes #15834

Description

I have added @wordpress/hooks for javascript hook and filter.

Fix 404 link
Fix 404 link
@@ -4,4 +4,4 @@

There are two types of hooks: [Actions](https://developer.wordpress.org/plugins/hooks/actions/) and [Filters](https://developer.wordpress.org/plugins/hooks/filters/). In addition to PHP actions and filters, WordPress also provides a mechanism for registering and executing hooks in JavaScript. This functionality is also available on npm as the [@wordpress/hooks](https://www.npmjs.com/package/@wordpress/hooks) package, for general purpose use.

You can also learn more about both APIs: [PHP](https://codex.wordpress.org/Plugin_API/) and [JavaScript](/packages/tree/master/packages/hooks).
You can also learn more about both APIs: [PHP](https://codex.wordpress.org/Plugin_API/) and [JavaScript](https://developer.wordpress.org/block-editor/packages/packages-hooks/).

This comment has been minimized.

Copy link
@gziolo

gziolo May 27, 2019

Member

This link needs to work also on GitHub:

Suggested change
You can also learn more about both APIs: [PHP](https://codex.wordpress.org/Plugin_API/) and [JavaScript](https://developer.wordpress.org/block-editor/packages/packages-hooks/).
You can also learn more about both APIs: [PHP](https://codex.wordpress.org/Plugin_API/) and [/packages/hooks/README.md).

This comment has been minimized.

Copy link
@gziolo

gziolo May 27, 2019

Member

@nitishkaila thanks for your contribution, can you update the link as suggested above before I merge this PR?

This comment has been minimized.

Copy link
@nitishkaila

nitishkaila May 27, 2019

Author Contributor

It's work on github too. I have already added full link in github. so it's definitely work.

Still if you have any query please let me know.

This comment has been minimized.

Copy link
@gziolo

gziolo May 27, 2019

Member

Yes, it does. However please check these document:
https://github.com/WordPress/gutenberg/blob/master/docs/contributors/document.md#using-links

There can be a different version of docs at https://developer.wordpress.org/ because it covers the latest stable version of WordPress and GitHub can be a few weeks ahead.

This comment has been minimized.

Copy link
@nitishkaila

nitishkaila May 27, 2019

Author Contributor

Thank you @gziolo to clarify. I have updated the link.

This comment has been minimized.

Copy link
@gziolo

gziolo May 27, 2019

Member

Thanks, I can imagine it's confusing but we operate with a very specific setup where we sync changes to WordPress core through npm packages so it enforces a set of rules to ensure everything works properly :)

Update with correct URL
Update with correct URL
@gziolo

gziolo approved these changes May 27, 2019

Copy link
Member

left a comment

Nice 🙇

Congrats on your first code contribution to Gutenberg!

@gziolo gziolo changed the title Fix 404 link Docs: Fix 404 link in filters document May 27, 2019

@gziolo gziolo added this to the 5.9 (Gutenberg) milestone May 27, 2019

@gziolo gziolo merged commit 70154bb into WordPress:master May 27, 2019

1 check failed

Travis CI - Pull Request Build Errored
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.