Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset the current branch before changing branches when releasing Gutenberg #15840

Merged
merged 1 commit into from May 27, 2019

Conversation

@youknowriad
Copy link
Contributor

commented May 27, 2019

When releasing the Gutenberg 5.8 RC1, I had an error at the end of the process (see the end of the recording https://asciinema.org/a/prYW5WryI9AfFUbFYZjAtJtuv )

npm install can create dirtiness in the package-lock.json file and the repo wasn't reset at the right moment. This fixes it.

@gziolo

gziolo approved these changes May 27, 2019

Copy link
Member

left a comment

It looks like the lock file is doing some strange things again :(

I saw that earlier today as well...

@gziolo gziolo added this to the 5.9 (Gutenberg) milestone May 27, 2019

@youknowriad youknowriad merged commit 325b26c into master May 27, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@youknowriad youknowriad deleted the fix/git-reset-on-release branch May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.